Re: [PATCH][ATM] assorted he driver cleanup

[Arnaldo Carvalho de Melo]

Em Thu, May 29, 2003 at 02:08:59PM -0400, chas williams escreveu:
> In message <[e-mail]>,Arnaldo Carvalho de Melo w
> rites:
> >> @@ -1067,46 +1044,39 @@
> >>  	 */
> >>  
> >>  	/* 4.3 pci bus controller-specific initialization */
> >> -	if (pci_read_config_dword(pci_dev, GEN_CNTL_0, &gen_cntl_0) != 0)
> >> -	{
> >> +	if (pci_read_config_dword(pci_dev, GEN_CNTL_0, &gen_cntl_0) != 0) {
> >>  		hprintk("can't read GEN_CNTL_0\n");
> >
> >Humm, shouldn't we release the irq here? What about using gotos for exception
> >handing?
> 
> what irq?  the irq is grabbed in he_init_irq.  if he_start() fails, we 
> call he_stop() and it frees the irq.

OK sir, sorry for the noise on this one :-)