Re: [PATCH] linux-2.5.69_subarch-fix_A0.patch

[Andi Kleen]

On Wed, May 14, 2003 at 07:37:09PM -0700, john stultz wrote:
> All,
> 	This patch fixes a circular dependency (a function in mach_apic.h
> requires hard_smp_processor_id() and hard_smp_processor_id() requires
> macros from mach_apic.h) that has been in the subarch code for a bit,
> but was hacked around with some #ifdefs. 
> 
> With the inclusion of the generic-subarch the hack was dropped and
> bigsmp and summit promptly broke. So this makes things compile again. 

What broke exactly? I thought worked around this problem for the generic
subarchitecture.

Accessing the APIC directly this way just to work around a bad include
looks quite ugly to me.

-Andi