Re: Partition check order in fs/partition/check.c?

[Peter Oberparleiter]

On Tuesday 01 April 2003 12:35, you wrote:
[info about acorn partitioning schemes]
Ok, thanks for the explanation about the scheme dependencies. I guess adding 
a comment like "/* this must come before msdos */" in the respective line of 
fs/partition/check.c could cut down in the number of people asking you the 
same question over and over again.. :-)

> > Also, is there a way to make the acorn test more specific?
>
> s/acorn/powertec/
>
> We may be able to check that start,start+size lies within the overall
> drive size.  Whether this solves the problem will depend upon the contents
> of sector 0 for the x86 drives which clash.  However, as drive sizes
> increase, this test will become less and less effective (and at 2TiB
> it doesn't help at all.
Hm, what do you think of these additional checks:

1. Check for overlap of partitions
2. Check for number of recognized partitions (i.e. size != 0) > 0 
3. Check for struct ptec_partition.unused1, unused2, unused5 == 0 (assuming 
they default to zero)

Anyway, thanks again for the info.

Regards,
  Peter Oberparleiter