Re: [PATCH][COMPAT] compat_sys_fcntl{,64} 1/9 Generic part

[Linus Torvalds]

On Wed, 12 Mar 2003, Stephen Rothwell wrote:
> 
> > Make the code _look_ good. Not look like SOMEBODY WHO CANNOT TYPE WITHOUT
> > THE SHIFT KEY. Make the thing take properly typed arguments, instead of
> > casting stuff two ways and backwards inside macros.
> 
> you mean like this?

Yes, this looks much more sane. If you _really_ want to be anal about 
typechecking (and also checking that nobody can possibly use a user 
pointer incorrectly), you make

	typedef struct {
		unsigned int val;
	} compat_uptr_t;

and then use

	static inline void *compat_ptr(compat_uptr_t uptr)
	{
		return (void *)uptr.val;
	}

which should still result in readable code.

		Linus