Re: [PATCH][COMPAT] compat_sys_fcntl{,64} 1/9 Generic part

Stephen Rothwell (sfr@canb.auug.org.au)
Wed, 12 Mar 2003 16:22:51 +1100

On Tue, 11 Mar 2003 21:02:09 -0800 (PST) Linus Torvalds <torvalds@transmeta.com> wrote:
>
> Why do you have to shout in the code with macro names from hell?

At least it is descriptive as opposed to an uncommented macro
called A ...

> Make the code _look_ good. Not look like SOMEBODY WHO CANNOT TYPE WITHOUT
> THE SHIFT KEY. Make the thing take properly typed arguments, instead of
> casting stuff two ways and backwards inside macros.

you mean like this?

static inline void *compat_ptr(compat_uptr_t uptr)
{
return (void *)uptr;
}

and (for s390x)

static inline void *compat_ptr(compat_uptr_t uptr)
{
return (void *)(uptr & 0x7fffffffUL);
}

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/