Re: Patch?: linux-2.5.59/sound/soundcore.c referenced non-existant errno variable

[Petr Vandrovec]

On Sat, Jan 18, 2003 at 09:40:36AM -0600, Raja R Harinath wrote:
> > -	if (fd == -1)
> > +	filp = filp_open(fn, 0, 0);
> > +	if (IS_ERR(filp))
> >  	{
> >  		printk(KERN_INFO "Unable to load '%s'.\n", fn);
> >  		return 0;
> >  	}
> [snip]
> 
> I noticed that do_mod_firmware_load is wrapped by a
> set_fs(get_gs())/set_fs(fs) pair in mod_firmware_load, presumably
> because it performs an 'int 0x80' kernel syscall in there.  The
> cleanup to use the VFS directly should probably kill the wrapper too.

vfs_read expects userspace pointer, so we must do set_fs() at least
around vfs_read, and so I left it around whole function, to minimize
changes in code.

In original message I asked whether I should convert firmware loader to 
the "if (error) goto quit;" style to move error handling to one place, 
but only answer I got was 'Ask Rob' ;-)

And as I do not have sound hardware which needs firmware, I do not
want to make more changes than absolutely necessary to the code I cannot
verify. Of course if you'll find someone with hardware...
						Best regards,
							Petr Vandrovec
							[e-mail]