Re: [PATCH] Proposed module init race fix.

[Rusty Russell]

On Wed, 15 Jan 2003 17:34:45 +0100
Roman Zippel <[e-mail]> wrote:
> >  void add_disk(struct gendisk *disk)
> >  {
> > +       /* It needs to be accessible so we can read partitions. */
> > +       make_module_live(disk->fops->owner);
> > +
> 
> After this the module can be removed without problems.

Good catch!  The core code should hold a reference during init.  This is
fixed in the new patch.

> >         disk->flags |= GENHD_FL_UP;
> >         blk_register_region(MKDEV(disk->major, disk->first_minor), disk->minors,
> >                         NULL, exact_match, exact_lock, disk);
> 
> blk_register_region() allocates memory, which can fail?

Looks like.  But the semantics are the same as before, for better or worse. 8(

Thanks!
Rusty.
-- 
   there are those who do and those who hang on and you don't see too
   many doers quoting their contemporaries.  -- Larry McVoy