Re: [PATCH] 2.5.56 sound/oss/sb_mixer.c bounds check

[Andrew Morton]

ryan wrote:
>> Yup.
>>
>> It would be better to do:
>>
>>     if (dev < 0 || dev >= ARRAY_SIZE(smw_mix_regs))
> 
> 
> yup, much better. i did a little housecleaning on the whole file, as 
> well as 2 more bounds checks in appropriate places.
> 
> i'm sorry to ask, but i'm new -- i've got a ~500 line patch, and my 
> email client is wrapping at 80 chars (unfortunately some lines run over 
> 80 chars), is sending an attachment in ascii format ok? i've seen some 
> patches sent as attachments, not sure.
> 

Oh let me rant. You're using mozilla.  I just raised a bug against its cute habit of
mangling outgoing text.  I've just spent four days trying to find a workable Linux
email client (sophisticated UI, sophisticated IMAP support, sophisticated searching,
doesn't mangle incoming or outgoing messages) and have failed.  Netscape 4.x is
still the closest.

kmail is good, but its threading view is hopeless

evolution merrily mangles stuff and is buggy as a bunch of bananas.

Mozilla likes to go for multi-minute CPU burns if you try to handle a large amount
of data.  And it mangles outgoing patches.

Of the text-based MUA's pine is the only one which seems to have respectable IMAP
support, but the interface is klunky.

Sigh.  Where were we?  Oh yes.   Inline text is best, attachments are fine.
text/plain if poss.

<send, mangle>