Re: [RFC] Consolidate vmlinux.lds.S files

[Eric W. Biederman]

Sam Ravnborg <[e-mail]> writes:

> Recently we have seen seveal changes to arch/*/vmlinux-lds.S,
> mainly introduced by the module support but also other changes.
> 
> This is first version, where I have converted i386, s390 and sparc64.
> The latter two is not tested, only to make sure it can be used by more
> than one platform.
> 
> include/asm-generic/vmlinux.lds contains common definitions.
> inserted below + three diffs.
> 
>  i386/vmlinux.lds.S    |  148 ++++++++++++++---------------------------------
>  s390/vmlinux.lds.S    |  138 +++++++++++++-------------------------------
>  sparc64/vmlinux.lds.S | 156 +++++++++++++++++++-------------------------------
> 
>  3 files changed, 149 insertions(+), 293 deletions(-)
> 
> The architecture specific files became smaller.
> And adding new stuff is easier.
> 
> If this the correct way of doing it - or do you have any better ways
> to do it?

You are changing the Language that vmlinux.lds.S is written in.
It appears to reduce readability by hiding information.  I'm not
in favor of it.

Eric