Re: Linux 2.4.21-pre3-ac4

[Benjamin Herrenschmidt]

On Sun, 2003-01-12 at 19:07, Alan Cox wrote:
> Various compile fixes, and the next stage of IDE updating. In particular
> the PIIX driver has been subjected to a full review of Intel chipset
> errata. I've also added the framework to fix the problems Ross Biro found
> but not yet enabled its use. Once enabled that should fix a lot of the
> problems with shared IRQ IDE. Handle with care as usual.

It seems it lacks the code to actually blast the cmd byte passed
as a parameter...

Also, how are we supposed to use it exactly ? We shall fill the taskfile
first I beleive, so I suppose we shall call ide_spin_wait_hwgroup()
first which gets us a channel locked and not busy, right ?

That would do something like:

  if (ide_spin_wait_hwgroup(drive))
	return -EBUSY;
  hwgroup->busy = 1;
  .. put stuffs in taskfile regs ..
  spin_unlock_irq(&io_request_lock);
  ide_execute_command(drive, ...)
  
Ànd then hopefully wait (wait_for_completion() ?) for some action by
the expiry or the handler, right ?

I'm just trying to make sure I understand the purpose of this new function...

Ben.