[PATCH] fix broken kallsyms on non-x86 archs

James Bottomley (James.Bottomley@SteelEye.com)
Sun, 12 Jan 2003 13:40:22 -0500


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-30694-1042396889-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

kallsyms is broken in parisc on 2.5.56 again because of assembler syntax
subtleties. This is the offending line:

printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n"

Note the `;' separating the two statements. On some platforms `;' is a
comment in assembly code, and thus the following .asciz is ignored. The fix
is attached.

James

--=_courier-30694-1042396889-0001-2
Content-Type: text/plain; name="tmp.diff"; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Description: tmp.diff
Content-Disposition: attachment; filename="tmp.diff"

===== scripts/kallsyms.c 1.6 vs edited =====
--- 1.6/scripts/kallsyms.c Thu Jan 2 04:02:18 2003
+++ edited/scripts/kallsyms.c Sun Jan 12 12:23:03 2003
@@ -144,7 +144,7 @@
for (k = 0; table[i].sym[k] && table[i].sym[k] == prev[k]; ++k)
;

- printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n", k, table[i].sym + k);
+ printf("\t.byte 0x%02x\n\t.asciz\t\"%s\"\n", k, table[i].sym + k);
last_addr = table[i].addr;
prev = table[i].sym;
}

--=_courier-30694-1042396889-0001-2--