Re: PATCH 2.5.x disable BAR when sizing

[Linus Torvalds]

In article <[e-mail]>,
Grant Grundler <[e-mail]> wrote:
>
>In April 2002, [e-mail] sent a 2.4.x patch to disable
>BARs while the BARs were being sized.  I've "forward ported" this patch
>to 2.5.x (appended).  turukawa's excellent problem description and
>original posting are here:
>	https://lists.linuxia64.org/archives//linux-ia64/2002-April/003302.html
>
>David Mosberger agrees this is an "obvious fix".

It is NOT an "obvious fix".

It breaks stuff horribly. When you turn off the MEM bit on the
northbridge, there are northbridges that will stop forwarding RAM<->PCI.

>We've been using this in the ia64 2.4 code stream since about August.

And it's CRAP.

DO NOT DO THIS. It locks up some machines at bootup. Hard. Total bus
lockup if you have legacy USB enabled (or anything else that does DMA,
for that matter) at the same time as probing the northbridge with this.

Trust me.  If you have some new silly ia64-specific bug, the fix is
_not_ to break real and existing hardware out there. 

We've had this "obviously correct" patch floating around several times,
and it even made it into the kernel at least once. It was reverted
because it is WRONG.

		Linus