Re: vt8235 fix, hopefully last variant

[John Reiser]

This is a multi-part message in MIME format.
--------------080404050005070200080207
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Vojtech Pavlik wrote:
> Can you guys try out this last take on a fix for your ATAPI device
> problems? Applies against clean 2.4.20.

Yes, the vt8235-atapi patch works for me; so did vt8235-dvd, but not vt8235-min.
Mitsumi FX4830T ATAPI CD-ROM, MSI KT3 Ultra2 mainboard (KT333), vt8235.

I modified the patch so that it would apply cleanly to RedHatLinux8.0
kernel-2.4.18-18.8.0 as part of "rpm -bb --target i686 kernel-2.4.18.spec".
The result is attached.

-- 
John Reiser, [e-mail]

--------------080404050005070200080207
Content-Type: text/plain;
 name="vt8235-atapi-jreiser.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="vt8235-atapi-jreiser.patch"

--- linux/drivers/ide/via82cxxx.c.orig	Thu Dec 19 08:35:20 2002
+++ linux/drivers/ide/via82cxxx.c	Thu Dec 19 08:43:10 2002
@@ -1,5 +1,5 @@
 /*
- * Version 3.35
+ * Version 3.36jreiser
  *
  * VIA IDE driver for Linux. Supported southbridges:
  *
@@ -129,7 +129,7 @@
 
 	via_print("----------VIA BusMastering IDE Configuration----------------");
 
-	via_print("Driver Version:                     3.35");
+	via_print("Driver Version:                     3.36jreiser");
 	via_print("South Bridge:                       VIA %s", via_config->name);
 
 	pci_read_config_byte(isa_dev, PCI_REVISION_ID, &t);
@@ -295,6 +295,10 @@
 		ide_timing_merge(&p, &t, &t, IDE_TIMING_8BIT);
 	}
 
+	/* Always use 4 address setup clocks on ATAPI devices */
+	if (drive->media != ide_disk)
+		t.setup = 4;
+ 
 	via_set_speed(HWIF(drive)->pci_dev, drive->dn, &t);
 
 	if (!drive->init_speed)

--------------080404050005070200080207--