Re: [PATCH] sys_poll SuS compliance fix

Jeff Garzik (jgarzik@pobox.com)
Wed, 18 Dec 2002 12:06:11 -0500


Linux Kernel Mailing List wrote:
> ChangeSet 1.942, 2002/12/18 10:33:48-02:00, manfred@colorfullife.com
>
> [PATCH] sys_poll SuS compliance fix

> diff -Nru a/fs/select.c b/fs/select.c
> --- a/fs/select.c Wed Dec 18 08:31:22 2002
> +++ b/fs/select.c Wed Dec 18 08:31:22 2002
> @@ -417,7 +417,7 @@
> int nchunks, nleft;
>
> /* Do a sanity check on nfds ... */
> - if (nfds > NR_OPEN)
> + if (nfds > current->files->max_fdset && nfds > OPEN_MAX)
> return -EINVAL;

The changeset description is awful, can you give us more details
Manfred? [also in the future can you please give Linus more description
with your patches?]

In particular, I wonder if "||" is more appropriate than "&&"?

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/