Re: [PATCH] : More module parameter compatibility for 2.5.52

[Jean Tourrilhes]

On Tue, Dec 17, 2002 at 03:20:10PM +1100, Rusty Russell wrote:
> In message <[e-mail]> you write:
> > 	Hi,
> > 
> > 	I've just downloaded 2.5.52 to try the new module parameter
> > support. Unfortunately, the letter 'c' was not implemented, and I need
> > it. This is used in few drivers (such as hp100, wavelan, wlan_cs...).
> 
> Cool, an undocumented type!  And they have explit sizes, and they're
> used in arrays.  Just wonderful.

	I can only say that they are more efficient than 's'...

> I prefer the fix below.  Does it work for you?
> 
> Rusty.

	With all due respect, your fix is quite ugly.
	And think about it this way : your new param architecture is
supposed to be flexible and supposed to allow modules to get
parameters in any shape or form. But, on the other hand, it's
impossible to implement something as simple as 'c' without ugly hacks.
	Maybe we can deduct from this that the new param API is not
flexible enough and that the simple addition of an opaque type (priv)
can have some value. From personal experience, most APIs that didn't
had mechanism to pass private data between an entity and the entity
handlers ended up regretting it and having to add it back at some
point.

	Have fun...

	Jean