Re: [PATCH] pcnet32 cable status check

[Jeff Garzik]

Kent Yoder wrote:
> Thus Spake Jeff Garzik:
> 
>>Looks good ;-)
> 
> 
>  Thanks,
> 
> 
>>One small thing -- since you appear to test all cases for (lp->mii) 
>>before calling mod_timer, I don't think you need to test lp->mii inside 
>>the timer...
> 
> 
>   Well, the reason I left that in there was so that another person could add 
> functionality to the watchdog if they wanted on a non-mii enabled card 
> without having to know that the check would need to be added. If that's not 
> that big a deal, I can remove it...

That's a fair enough argument, patch applied.