Re: Question regarding Qdisc.stats

Werner Almesberger (wa@almesberger.net)
Sun, 15 Sep 2002 02:46:16 -0300


Ravikiran G Thirumalai wrote:
> Where do the Qdisc.stats show up? in /proc?

No, only on (rt)netlink.

> (Assuming CONFIG_NET_SCHED is not defined)

In this case, the statistics are not usefully accessible. The
tx_dropped you get with ifconfig (or such) comes from the device
level, not the traffic control subsystem.

> qdisc_copy_stats with 'TCA_STATS' attribute, but where is it being
> reported? or what is it being used for ?? Specifically, does
> Qdisc.stats.drops get reported anywere?

Yep, e.g. in iproute2/tc/tc_qdisc.c:print_tcstats

> While I am at it, I see that qdisc->enqueue routines kfree the skb with the
> dev->queue_lock held (when the enqueue routine drops the packet --
> NET_XMIT_DROP) from dev_queue_xmit. kfree_skb can be done outside the
> lock.... right? I can make a patch for this if I am not missing something.....

That certainly sounds good to me.

- Werner

-- 
  _________________________________________________________________________
 / Werner Almesberger, Buenos Aires, Argentina         wa@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/