Re: [PATCH] 2.5.17 build hides errors

[Kai Germaschewski]

On Tue, 21 May 2002, Jan Harkes wrote:

> The following patch allows the kernel compile to abort on errors again.
> It also fixes some missing includes in filesystems that were broken by
> the removal of locks.h.

Yup, just fixed the same problem - should better have gone through my 
lkml mail before. My patch is slightly different (does '|| exit $?' 
instead), but achieves the same thing.

Actually, I think I like yours better.

At least this proves that it's obviously possible for other people to
grasp what's going in Rules.make - which is good ;-)

--Kai

> diff -urN linux-2.5.17/Rules.make linux-trivial/Rules.make
> --- linux-2.5.17/Rules.make	Tue May 21 01:46:03 2002
> +++ linux-trivial/Rules.make	Tue May 21 03:35:35 2002
> @@ -380,5 +380,5 @@
>  if_changed = $(if $(strip $? \
>  		          $(filter-out $($(1)),$(cmd_$@))\
>  			  $(filter-out $(cmd_$@),$($(1)))),\
> -	       @echo $($(1)); $($(1)); echo 'cmd_$@ := $($(1))' > .$@.cmd)
> +	       @echo $($(1)) && $($(1)) && echo 'cmd_$@ := $($(1))' > .$@.cmd)
>