Re: 2.5.17: hfs no go

[Kai Germaschewski]

On Mon, 20 May 2002, A Guy Called Tyketto wrote:

> gcc -D__KERNEL__ -I/usr/src/linux-2.5.15/include -Wall -Wstrict-prototypes 
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe 
> -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -DMODULE 
> -DMODVERSIONS -include /usr/src/linux-2.5.15/include/linux/modversions.h 
> -DKBUILD_BASENAME=inode -c -o inode.o inode.c
> inode.c: In function `hfs_prepare_write':
> inode.c:242: dereferencing pointer to incomplete type
> gcc -D__KERNEL__ -I/usr/src/linux-2.5.15/include -Wall -Wstrict-prototypes 
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe 
> -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -DMODULE 
> -DMODVERSIONS -include /usr/src/linux-2.5.15/include/linux/modversions.h 
> -DKBUILD_BASENAME=mdb -c -o mdb.o mdb.c

Okay, I think Christoph Hellwig already gave you the right hint on how to 
fix the actual problem in inode.c.

However, this snippet also shows a glitch I introduced, i.e. make 
wouldn't stop the build on error immediately, as it used to.

So here's the fix for that one.

--Kai

# --------------------------------------------
# 02/05/21	[e-mail]	1.584
# kbuild: Stop immediately on error
# 
# This patch restores the previous behavior of stopping the build
# immediately on error (unless the -k option is given to make)
# --------------------------------------------
#
diff -Nru a/Rules.make b/Rules.make
--- a/Rules.make	Tue May 21 09:08:38 2002
+++ b/Rules.make	Tue May 21 09:08:38 2002
@@ -380,5 +380,5 @@
 if_changed = $(if $(strip $? \
 		          $(filter-out $($(1)),$(cmd_$(@F)))\
 			  $(filter-out $(cmd_$(@F)),$($(1)))),\
-	       @echo $($(1)); $($(1)); echo 'cmd_$(@F) := $($(1))' > $(@D)/.$(@F).cmd)
+	       @echo $($(1)); $($(1)) || exit $$?; echo 'cmd_$(@F) := $($(1))' > $(@D)/.$(@F).cmd)