Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)

[Daniel Phillips]

On January 7, 2002 10:25 pm, Jeff Garzik wrote:
> Daniel Phillips wrote:
> > The two main problems I see with this are:
> > 
> >   - If a filesystem doesn't want to use genericp_ip/sbp then fs.h has
> >     to know about it.  Why should fs.h know about every filesystem in
> >     the world?
> 
> We keep type information through this method.  There is no ugly casting.

There is a far uglier 1) tying of fs.h to every filesystem in the world 2) a 
gratuitous extra pointer dereference and 3) a pointer field wasted in every 
inode.

In the ugly contest, you win, hands down.

--
Daniel