Re: [PATCH] strtok --> strsep in framebuffer drivers

Linus Torvalds (torvalds@transmeta.com)
Thu, 25 Oct 2001 17:41:00 -0700 (PDT)


On Thu, 25 Oct 2001, René Scharfe wrote:
>
> Yes. I assumed my compiler (gcc 2.96) was misbehaving by reporting all
> that warnings about code which is actually just some normal C code. But
> after some consideration I see that it can help greatly in case of
> typos and so on.

Please use an explicit test - I know gcc suggest just an extra set of
parenthesis, but I'm personally convinced that is just because some gcc
people have been damaged by too much LISP.

I think

if ((a = b))

looks nothing but stupid, while

if ((a = b) != 0)

"explains" the parenthesis..

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/