RE: ACPI fix + comments

Grover, Andrew (andrew.grover@intel.com)
Wed, 31 Jan 2001 14:23:21 -0800


The problem the diff below fixes is a BIOS issue - the _STA control method
should always be returning a value, but in this case it doesn't. The
approach we're taking is "get everything working and THEN worry about broken
ACPI implementations" and hopefully in the meantime, people will release
fixed BIOSs ;-).

> And working around error in running sta makes it actually
> usefull. This is ugly workaround, should not be applied to official
> tree.
[snip]

> And now questions: Why are numbers reported in hexadecimal? Reporting
> voltage in hexadecimal is nice nonsense to me...

This is a temporary interface, just to see if we're returning values
properly. Your points below are well taken. People really care about
minutes/percentage remaining. In your opinion should we just report that
through /proc or should we keep the data low-level like it is now, and have
a user app do the math, or what?

> I believe that we should keep description: value format, and switch to
> decimal. Plus, units are nonsensical in some cases:
>
> Remaining Capacity: 59a
> ~~~ should be in mAh, probably

[snip]

> PS: What should be difference between _info and _status? Both contain
> fields that change with time...

*info corresponds with the _BIF control method, and *status with _BST. I
thought _BIF stuff is static - is it not?

Regards -- Andy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/