Re: kernel BUG at inode.c:889!

[Andreas Dilger]

I previously wrote:
> Below is a patch which should fix this.  It _should_ prevent you from
> mounting this filesystem in the first place, and should also stop the BUG
> in inode.c.  I'm not 100% sure of correctness, however:
> - is calling clear_inode() in these error cases OK?
> - is calling dput() the right thing to do for the root dentry?  This
>   is what kill_super() does when cleaning up the filesystem.
> 
> Cheers, Andreas
> ============================================================================
> --- fs/ext2/super.c.orig	Tue Jan 23 17:24:45 2001
> +++ fs/ext2/super.c	Wed Jan 31 12:27:25 2001
> @@ -628,13 +628,19 @@
>  	 */
>  	sb->s_op = &ext2_sops;
>  	sb->s_root = d_alloc_root(iget(sb, EXT2_ROOT_INO));
> -	if (!sb->s_root) {
> +	if (!sb->s_root || !S_ISDIR(sb->s_root->d_inode) ||

This should be !S_ISDIR(sb->s_root->d_inode->i_mode).

> +	    !sb->s_root->d_inode->i_blocks || !sb->s_root->d_inode->i_size) {
> +		if (sb->s_root) {
> +			dput(sb->s_root);
> +			sb->s_root = NULL;
> +			printk ("EXT2-fs: corrupt root inode, run e2fsck\n");
> +		} else
> +			printk ("EXT2-fs: get root inode failed\n");

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert