Re: [PATCH] Add SELinux module to 2.6.0-test1

[Greg KH]

On Mon, Jul 14, 2003 at 03:05:04PM -0400, Stephen Smalley wrote:
> The patch available from
> http://www.nsa.gov/selinux/lk/2.6.0-test1-addselinux.patch.gz adds the
> SELinux module under security/selinux and modifies the security/Makefile
> and security/Kconfig files for SELinux.

Some minor coding style nits:
	- you are creating your own typedefs, please don't.  Use the
	  "struct foo" style instead.
	- you have a number of printk() calls without a logging level.
	  Hm, looks like some of the functions doing this aren't ever
	  called at all (avc_dump_cache() is one example)...
	- your function style should be changed to take advantage of the
	  kerneldoc functionality.  avc_lookup() is a good example of
	  something that could benifit from this (don't put comments
	  within a function declaration...)

Other than that, the coding style looks real good.

thanks,

greg k-h