Re: radeonfb patch for 2.4.22...

On Mon, 14 Jul 2003, Marcelo Tosatti wrote:

> 
> Ah really? I though that his changes were not merged in your 0.1.8 patch.
> 
> So can I just revert his patch and accept your instead that all of his
> stuff is in ? Whoaa, great.

Here is an xcept from ChangeLong section of the driver from the patch I
sent you:

+ *     2003-04-12      Mac PowerBook sleep fixes, Benjamin Herrenschmidt,
+ *                     0.1.8

I agree this isn't very descriptive of this other fixes and I can change
that, but a lot of his Mac changes have been merged in, but apparently
nobody has taken the time to actually look at that patch.  If there are
things that are missing then I asked him to tell me, which he has not so I
assume there are none.

> Ani, I received complains that you were not accepting patches from Ben. He
> needs that code in.

This is not true, see the above.  Also, its hard to "accept patches" from
people if you do NOT recieve any patches from them!  Ben's style is to get
the maintainers of drivers to go around and search for his personal tree
and do their own diffs from that tree, instead of him sending a patch to
the maintainer.

> > If so then please let me know, so I don't waste anymore of my time on
> > this driver and let someone else play these silly games and maintain it.
> 
> I prefer playing no silly games in the 2.4 stable series, as I've been
> trying to do so far. If you had accepted Ben's changes in the first place
> I wouldnt need to apply his patch.

I did accept most all of his changes when this patch was made (originally
I sent it May 12, which you did not merge into 2.4.21, probably because I
sent it during the RC stange, but after that you lost the patch ?).  Since
that time, I assume Ben has made some other changes, which I have not
recieved any word about.

Please don't accuse people of not accpeting patches when that is simply 
not true, as it can be easily said for you too.