Re: [PATCH] minor optimization for EXT3

[Andi Kleen]

Alex Tomas <[e-mail]> writes:
> +			if (i == start + inodes_per_buffer) {
> +				/* all inodes (but our) are free. so, we skip I/O */

Won't this make undeletion a lot harder? Deleted inodes will now be trashed
at will, so you cannot use their contents anymore. 

Also dtimes in free inodes  can be now lost, can't they? Did you check 
if that causes problems in fsck?  [my understanding was that ext2/3 fsck relies on the 
dtime to make some heuristics when recovering files work better]

Maybe it should be an mount option so that users can trade performance against
better recoverability.

-Andi