Re: [PATCH] 2.4.22-pre3: P3 and P4 for chekc_gcc

[Jeff Garzik]

J.A. Magallon wrote:
> --- linux-2.4.21-bp1/arch/i386/Makefile.orig	2003-06-18 23:40:25.000000000 +0200
> +++ linux-2.4.21-bp1/arch/i386/Makefile	2003-06-18 23:59:25.000000000 +0200
> @@ -53,11 +53,11 @@
>  endif
>  
>  ifdef CONFIG_MPENTIUMIII
> -CFLAGS += -march=i686
> +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
>  endif
>  
>  ifdef CONFIG_MPENTIUM4
> -CFLAGS += -march=i686
> +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
>  endif

Looks ok to me (I run this patch locally, and also am the one who 
submitted the check_gcc patch).

I haven't had any problems at all, but I'm curious if anyone has any 
negative feedback...  It's rather easy to be conservative and ignore the 
patch, since -march=i686 should always work.

	Jeff