Re: crypto API and IBM z990 hardware support

David S. Miller (davem@redhat.com)
Mon, 07 Jul 2003 19:53:50 -0700 (PDT)


From: Christoph Hellwig <hch@infradead.org>
Date: Mon, 7 Jul 2003 08:09:29 +0100

On Wed, Jul 02, 2003 at 07:35:16PM +1000, James Morris wrote:
> So, there might be:
>
> crypto/aes.c
> crypto/arch/i386/aes.s

crypto/arch/ sounds like a bad idea. We really should avoid arch code
outside arch/ and include/asm*. So arch/<foo>/crypto/ as suggested by
Thomas is much better.

I totally disagree. I think the way we do things today is _STUPID_.
We put arch code far away from the generic version which makes finding
stuff very difficult for people inspecting the code for the first time.

For example, the fact that I have to go groveling in
arch/foo/lib/whoknowswhatfile.whoknowswhatextension to look at
the memcpy/checksum/whatever implementation is completely busted.

So, I totally support making crypto/arch/ directories.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/