Re: [BUG] heavy disk access sometimes freezes 2.5.73-mm[123]

[Chris Mason]

On Mon, 2003-07-07 at 11:58, Thomas Schlichter wrote:
> On Monday 07 July 2003 05:30, Barry K. Nathan wrote:
> > On Sun, Jul 06, 2003 at 07:37:22PM -0700, Andrew Morton wrote:
> > > Nick Piggin <[e-mail]> wrote:
> > >
> > > Barry says the problem started with 2.5.73-mm1.  There was a reiserfs
> > > patch added in that kernel.
> > >
> > > Does a `patch -R' of this fix it up?
> >
> > [patch snipped]
> >
> > Yes, backing that patch out fixes it.
> 
> I had similar problems with my reiserfs root FS. For me backing out only the 
> second chunk of the patch made it, too. I've attached the patch I used for 
> that. If someone sees something really bad I'm doing with this please write, 
> because I'm playing with my root FS... ;-)

> diff -u linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c.orig linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c
> --- linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c.orig	2003-06-23 09:26:10.000000000 -0700
> +++ linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c	2003-06-23 09:26:10.000000000 -0700
> @@ -190,9 +190,6 @@ unmap_buffers(struct page *page, loff_t 
>          }
>  	bh = next ;
>        } while (bh != head) ;
> -      if ( PAGE_SIZE == bh->b_size ) {
> -	ClearPageDirty(page);
> -      }
>      }
>    } 
>  }

Heh, you read my mind.  It makes more sense for this hunk to be causing
problems than the first one.  Still we should be allowed to clear the
dirty bit since we've cleaned all the buffers on the page.

-chris