Re: [PATCH 2.5.74-mm2] nbd: make nbd and block layer agree about

Andrew Morton (akpm@osdl.org)
Sun, 6 Jul 2003 15:03:33 -0700


Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Also, I wonder if you found a bug/oversight in set_blocksize -- it sets
> bd_inode->i_blkbits but not bd_inode->i_size. I think it should set
> i_size also. Maybe Andrew or Al can confirm/refute this assertion.

set_blocksize() sets, err, the blocksize.

Lou was wanting to export bd_set_size() for setting i_size. But
bd_set_size() goes and tries to set the blocksize too.

So the patch as-is will do I think, unless someone feels there's a need to
go and rework these things.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/