That's a fat daddy list of locks you got there.
> + NETSTAT_TYPE _rx_packets; /* total packets received */
> + NETSTAT_TYPE _tx_packets; /* total packets transmitted */
> + NETSTAT_TYPE _rx_bytes; /* total bytes received */
> + NETSTAT_TYPE _tx_bytes; /* total bytes transmitted */
> + NETSTAT_TYPE _rx_errors; /* bad packets received */
> + NETSTAT_TYPE _tx_errors; /* packet transmit problems */
> + NETSTAT_TYPE _rx_dropped; /* no space in linux buffers */
> + NETSTAT_TYPE _tx_dropped; /* no space available in linux */
> + NETSTAT_TYPE _multicast; /* multicast packets received */
> + NETSTAT_TYPE _collisions;
Increasing user-visible sizes arbitrarily breaks stuff. Having
config-dependent types like this increases complexity.
Short term, just sample the stats more rapidly.
Long term, I suppose with 10GbE we should start thinking about this.
Personally, I would prefer to make the standard net device stats
available in the format already exported by ETHTOOL_GSTATS -- which I
note uses u64's for its counters, and it's easily extensible. I
received a request for this just today, even.
Jeff
P.S. Please cc netdev@oss.sgi.com for networking discussions.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/