Right. *That* is what I wanted to know: whether those were really
part of the backtrace or just noise. I'll forward to Linus.
> > I think you can do it easily in module_finalize... or if we were
> > ambitious we'd extract only the function symbols rather than keeping
> > the whole strtab and symtab.
>
> Apart from the dubious writing to a const * pointer, yes I can (it's
> what I'm doing now). There is some annoyance in that module_finalize
> isn't told where the string or symbol tables are, so I have to find them
> again.
My mistake: add_kallsyms should be above module_finalize, which means
you can just use the mod->symtab and mod->strtab members.
How's this?
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.73-bk7/kernel/module.c tmp/kernel/module.c
--- linux-2.5.73-bk7/kernel/module.c 2003-06-15 11:30:11.000000000 +1000
+++ tmp/kernel/module.c 2003-07-01 11:09:57.000000000 +1000
@@ -1349,7 +1349,15 @@ static void add_kallsyms(struct module *
mod->symtab[i].st_info
= elf_type(&mod->symtab[i], sechdrs, secstrings, mod);
}
-#endif
+#else
+static inline void add_kallsyms(struct module *mod,
+ Elf_Shdr *sechdrs,
+ unsigned int symindex,
+ unsigned int strindex,
+ const char *secstrings)
+{
+}
+#endif /* CONFIG_KALLSYMS */
/* Allocate and load the module: note that size of section 0 is always
zero, and we rely on this for optional sections. */
@@ -1603,14 +1611,12 @@ static struct module *load_module(void _
percpu_modcopy(mod->percpu, (void *)sechdrs[pcpuindex].sh_addr,
sechdrs[pcpuindex].sh_size);
+ add_kallsyms(mod, sechdrs, symindex, strindex, secstrings);
+
err = module_finalize(hdr, sechdrs, mod);
if (err < 0)
goto cleanup;
-#ifdef CONFIG_KALLSYMS
- add_kallsyms(mod, sechdrs, symindex, strindex, secstrings);
-#endif
-
mod->args = args;
if (obsparmindex) {
err = obsolete_params(mod->name, mod->args,
-- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/