Re: [2.5 patch] remove two unused variables from mxser.c

Adrian Bunk (bunk@fs.tum.de)
Sat, 28 Jun 2003 04:39:36 +0200

On Fri, Jun 20, 2003 at 02:31:06PM +1000, Rusty Russell wrote:
> In message <20030619231222.GF29247@fs.tum.de> you write:
> > The patch below removes two unused variables from drivers/char/mxser.c .
>
> While you're there, would you fix the init returning "-1" for no good
> reason at the bottom, too? (I don't think they really meant EPERM).

There is at least one other driver under drivers/char/ doing the
same...

Which return code do you suggest?

> Thanks,
> Rusty.

cu
Adrian

-- 


       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/