Re: 2.4.21rc8aa1

[J.A. Magallon]

Hi,

On 06.12, Andrea Arcangeli wrote:
> This version has some experimental change to the blkdev layer (latency
> fixes from Chris and Nick too plus the backout of the rc6 latency change
> to see if we can fix it w/o generating overscheduling, especially
> because it doesn't sound the right fix), so I would recommend some
> beating before doing anything critical with it. I would expect it as
> worse to deadlock with some task in D state. It worked fine for me so
> far but I didn't run big stress yet. In theory it should be better, but
> I just wanted to give a warning until it is better tested ;).
> 
> URL:
> 
> 	http://www.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.21rc8aa1.gz
> 	http://www.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.21rc8aa1/
> 

In sg.c, gcc shouts on:

    PRINT_PROC("%u\t%hu\t%hd\t%hu\t%d\t%d\n",
           shp->unique_id, shp->host_busy, shp->cmd_per_lun,
           shp->sg_tablesize, (int)shp->unchecked_isa_dma,
           (int)shp->hostt->emulated);

shp->host_busy should be accessed through atomic_read(), I think.

-- 
J.A. Magallon <[e-mail]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.21-jam1 (gcc 3.3 (Mandrake Linux 9.2 3.3-2mdk))