Re: [PATCH] unexpected IO-APIC update

Maciej W. Rozycki (macro@ds2.pg.gda.pl)
Wed, 25 Jun 2003 18:11:06 +0200 (MET DST)


On Wed, 25 Jun 2003, Randy.Dunlap wrote:

> | But the ugliness part I care about, and I wonder if it wouldn't be better
> | in this case to just make the register definition a "union", and have
> | something like
> |
> | union reg_03 {
> | u32 value;
> | struct {
> | u32 boot_DT:1,
> | reserved:31;
> | } bits;
> | };
[...]
> Sure, I'll do that.

Perhaps using "raw" instead of "value" would be prettier and certainly we
would save two characters per reference. ;-) Anyway, it's indeed a good
opportunity to do a clean-up while fiddling with these bits.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/