Re: 2.5.73 -- Uninitialised timer! (i386)

[Mikael Pettersson]

Andrew Morton writes:
 > Mikael Pettersson <[e-mail]> wrote:
 > >
 > > Apply the patch below (which I posted to LKML yesterday btw).
 > >  2.5.73 incorrectly removed the workaround needed to prevent
 > >  gcc-2.95.x from miscompiling spinlocks on UP (they become
 > >  empty structs, and gcc-2.95.x has problems with those).
 > 
 > Are you sure?  I saw no problems with 2.95.3.  Maybe it's
 > a 2.95.4 problem?

I know the problem exists in 2.95.3 since that's the one I
used for my initial 2.5.73 testing. Having seen the spinlock.h
patch, I strongly suspected things would break.

If I remember correctly, the empty struct miscompilation exists
in all old egcs and gcc-2.95 versions, but was fixed during 3.0
development, so 2.96 is apparently also Ok.

/Mikael