Re: [patch] kprobes for 2.5.73 with single-stepping out-of-line

[Andi Kleen]

"Vamsi Krishna S ." <[e-mail]> writes:

> +static struct kprobe *current_kprobe;

This global variable is quite unclean. It looks like it is for passing
function arguments around. Why is it needed? 

> +#define KPROBE_HASH_BITS 6
> +#define KPROBE_TABLE_SIZE (1 << KPROBE_HASH_BITS)
> +
> +static struct list_head kprobe_table[KPROBE_TABLE_SIZE];

Use hlists?

-Andi