Re: [PATCH] loop.c - part 1 of many

[Christoph Hellwig]

On Mon, Jun 23, 2003 at 10:40:32AM +0200, [e-mail] wrote:
> Why do you think that might be a good idea? General elegance?
> The array is legacy only - it will not grow.
> It has length 20, and only three entries are frequently used:
> 18 for CryptoAPI, 16 for loopAES, 0 for no encryption.

Having fixed arrays for extenions is generally a bad design, yes.
Also selection of those extensions by magic number is very very bad,
IMHO we should replace it with a by-name selection before any other
transformation is added to the kernel so we can just special-case the
existing two onesand stop worrying about magic numbers.