Re: [PATCH] loop.c - part 1 of many

[Christoph Hellwig]

On Mon, Jun 23, 2003 at 03:27:51AM +0200, [e-mail] wrote:
> -static int figure_loop_size(struct loop_device *lo)
> +static int
> +figure_loop_size(struct loop_device *lo)

This moves away from Documentation/CondingStyle..

>  int loop_register_transfer(struct loop_func_table *funcs)
>  {
> -	if ((unsigned)funcs->number > MAX_LO_CRYPT || xfer_funcs[funcs->number])
> +	unsigned int n = funcs->number;
> +
> +	if (n >= MAX_LO_CRYPT || xfer_funcs[n])
>  		return -EINVAL;
> -	xfer_funcs[funcs->number] = funcs;
> -	return 0; 
> +	xfer_funcs[n] = funcs;
> +	return 0;
>  }

Once you start touching loop_{,un}register_transfer please also get
rid of the array in favour of a linked list..