--=_courier-7796-1056294186-0001-2
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, 2003-06-22 16:07:14 +0200, Daniel Phillips <phillips@arcor.de>
wrote in message <200306221607.15232.phillips@arcor.de>:
> Hi Alan,
>=20
> On Saturday 21 June 2003 14:31, Alan Cox wrote:
> > On Sul, 2003-06-15 at 19:36, Geert Uytterhoeven wrote:
>=20
> How about:
>=20
> #define if_pci(tokens...) tokens
>=20
> int pnp_add_irq_resource(struct pnp_dev *dev, int depnum, struct pnp_i=
rq *data)
> {
> if_pci(int i);
> ...
> }
>=20
> Admittedly uglier than just having the warning disabled by default.
Even whilest I don't like defining variables where I need them (at an
opening "{" or like in "for (int i, i < x, i++)" as Linus suggested it),
this is quite ugly, too. "if_pci(int i)" looks linke an uglyfied
function call, and even while being ugly, it should basically "work"
like a function call. Here, it doesn't, so I consider this a Bad Thing.
MfG, JBG
--=20
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg
fuer einen Freien Staat voll Freier B=FCrger" | im Internet! | im Ira=
k!
ret =3D do_actions((curr | FREE_SPEECH) & ~(IRAQ_WAR_2 | DRM | TCPA));
--=_courier-7796-1056294186-0001-2
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE+9cR0Hb1edYOZ4bsRAvEqAJwN1XA5xr90HB7Fyh06sm2hsvCKzgCeIc0C
6GZfBvvKhKMFBcf7hQIS3p0=
=uMvn
-----END PGP SIGNATURE-----
--=_courier-7796-1056294186-0001-2--