Re: [PATCH] Permit big console scrolls

[Geert Uytterhoeven]

On Sun, 22 Jun 2003, Andrew Morton wrote:
> Geert Uytterhoeven <[e-mail]> wrote:
> >
> > > -			if (get_user(lines, (char *)arg+1)) {
> >  						    ^^^^^
> >  > +			if (get_user(lines, (s32 *)((char *)arg+4))) {
> >  							    ^^^^^
> >  >  				ret = -EFAULT;
> >  >  			} else {
> >  >  				scrollfront(lines);
> > 
> >  Why was the `arg+1' changed to `arg+4'? Do we really want to skip 12 bytes?
> 
> It skips three bytes?

Oops, you're right. But my first question remains: why skip 3 bytes?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds