Re: [2.5 patch] yam.c: return IRQ_NONE in error case

[Adrian Bunk]

On Fri, Jun 20, 2003 at 02:34:42PM +1000, Rusty Russell wrote:
> In message <[e-mail]> you write:
> > Please check whether the following patch to return IRQ_NONE in case of
> > errors is correct:
> > 
> > --- linux-2.5.72-mm2/drivers/net/hamradio/yam.c.old	2003-06-20 01:57:02.000000000 +0200
> > +++ linux-2.5.72-mm2/drivers/net/hamradio/yam.c	2003-06-20 01:57:41.000000000 +0200
> > @@ -742,7 +742,7 @@
> >  
> >  			if (--counter <= 0) {
> >  				printk(KERN_ERR "%s: too many irq iir=%d\n", dev->name, iir);
> > -				return;
> > +				return IRQ_NONE;
> >  			}
> 
> IRQ_HANDLED, I think: it did handle them, but decided it was
> livelocked and exited.

akpm already sent a better fix to Linus.

> Cheers,
> Rusty.

Thanks
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed