Re: [2.5 patch] 2.5.72: moxa.c doesn't compile

Rusty Russell (rusty@rustcorp.com.au)
Fri, 20 Jun 2003 14:28:13 +1000

In message <20030619185352.GB421@ananke.com.br> you write:
> @@ -654,7 +658,7 @@
> if (ch == NULL)
> return (0);
> port = ch->port;
> - save_flags(flags);
> + local_save_flags(flags);
> if (from_user) {
> if (count > PAGE_SIZE)
> count = PAGE_SIZE;
> @@ -662,17 +666,17 @@
> if (copy_from_user(moxaXmitBuff, buf, count)) {
> len = -EFAULT;
> } else {
> - cli();
> + spin_lock_irqsave(&moxa_lock, flags);

Just drop the local_save_flags() altogether; it's redundant.

> /*********************************************
> @@ -751,11 +755,11 @@
> if (ch == NULL)
> return;
> port = ch->port;
> - save_flags(flags);
> - cli();
> + local_save_flags(flags);
> + spin_lock_irqsave(&moxa_lock, flags);

Here too...

Cheers,
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/