Re: [PATCH CYCLADES 1/2] fix cli()/sti() for ISA Cyclom-Y boards

On Wed, Jun 18, 2003 at 05:48:17PM -0400, John Stoffel wrote:
  
> -    save_flags(flags); cli();
> +    spin_lock_irqsave(&isa_card_lock, flags);
>  
>      if ((e1 = tty_unregister_driver(cy_serial_driver)))
>              printk("cyc: failed to unregister Cyclades serial driver(%d)\n",
>  		e1);
>  
> -    restore_flags(flags);
> +    spin_unlock_irqrestore(&isa_card_lock,flags);

It doesn't fix the problem and only makes the compile trouble go away.
Not to mention anything else, you are relying on a lot of code being
non-blocking.

Could you explain what is protected by disabling interrupts and taking
a spinlock here?