Re: [PATCH] make cramfs look less hostile

[Jörn Engel]

On Sun, 15 June 2003 19:03:49 +0100, Christoph Hellwig wrote:
> On Sun, Jun 15, 2003 at 07:58:15PM +0200, Jörn Engel wrote:
> > Ok, you win this one.  Leaves this case:
> > $ mount /dev/somewhere /mnt
> > cramfs: wrong magic
> > $ echo $?
> > 0
> > $
> 
> Umm, please explain.  You got a sucessfull mount of a non-cramfs
> filesystem type but an error from cramfs?  What version of mount
> do you use?

Actually, that is what I expect to get tomorrow, when I have access to
hardware and can verify it.

> It's not a debug printk.  Please leave the messages in, it's really
> helpful to see what failed when mount doesn't succeed.

Yes, I agree.  It is any the "Cramfs didn't find it's magic number,
now we'll try another filesystem instead. Usually this should be
harmless and you can safely ignore this message." that bothers me,
because the current wording sounds more like "Something terrible has
happened, go and find someone to bug with this."

What do you propose instead?

Jörn

-- 
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein