Re: [PATCH] make cramfs look less hostile

[Christoph Hellwig]

On Sun, Jun 15, 2003 at 07:58:15PM +0200, Jörn Engel wrote:
> Ok, you win this one.  Leaves this case:
> $ mount /dev/somewhere /mnt
> cramfs: wrong magic
> $ echo $?
> 0
> $

Umm, please explain.  You got a sucessfull mount of a non-cramfs
filesystem type but an error from cramfs?  What version of mount
do you use?

> Here I consider the message evil as well.  The patch below on the
> other hand might go a little too far.  All the other printk()s are
> rare and might hold some useful information for normal users as well.
> 
> Any arguments for or against this patch?

It's not a debug printk.  Please leave the messages in, it's really
helpful to see what failed when mount doesn't succeed.