Re: [PATCH] remove superfluous inode superblock check from shmem_mmap

[Hugh Dickins]

On Mon, 16 Jun 2003, James Morris wrote:
> This patch against current 2.5 bk removes a (now) unecessary check for an 
> inode superblock in shmem_mmap().  In the current kernel, all inodes must 
> be associated with a superblock.

Thanks, looks good to me.  I don't believe an inode with NULL i_sb
could ever have got to shmem_mmap - it's just a check copied over
from an old generic_file_mmap.

Andrew, please apply: thank you.
Hugh

diff -purN -X dontdiff bk.pending/mm/shmem.c bk.w1/mm/shmem.c
--- bk.pending/mm/shmem.c	2003-06-16 00:56:13.000000000 +1000
+++ bk.w1/mm/shmem.c	2003-06-16 02:06:55.142303751 +1000
@@ -1010,7 +1010,7 @@ static int shmem_mmap(struct file *file,
 	struct inode *inode = file->f_dentry->d_inode;
 
 	ops = &shmem_vm_ops;
-	if (!inode->i_sb || !S_ISREG(inode->i_mode))
+	if (!S_ISREG(inode->i_mode))
 		return -EACCES;
 	update_atime(inode);
 	vma->vm_ops = ops;