Re: [PATCH] make cramfs look less hostile

[Jörn Engel]

On Sun, 15 June 2003 18:26:42 +0100, Christoph Hellwig wrote:
> On Sun, Jun 15, 2003 at 06:05:24PM +0200, Jörn Engel wrote:
> > 
> > This thing has been biting me now and again.  "cramfs: wrong magic\n"
> > looks like an error condition to most people and thus creates bug
> > reports.  But there is no bug per se in having cramfs support in the
> > kernel and booting from a jffs2 rootfs.  So instead of teaching the
> > users over and over, how about this little one-liner?
> 
> Umm, cramfs_fill_super has a silent parameter that's true for
> probing the root filesystem.  I'd suggest disabling the printk
> completly if it's set.

Good idea, but only at first glance.  cramfs_fill_super() always gets
called with silent=1.  So if "(!silent) printk(...);" is functionally
equivalent to ";".

Jörn

-- 
The competent programmer is fully aware of the strictly limited size of
his own skull; therefore he approaches the programming task in full
humility, and among other things he avoids clever tricks like the plague. 
-- Edsger W. Dijkstra