Re: [PATCH] udev enhancements to use kernel event queue

[Oliver Neukum]

> +
> +	spin_lock(&sequence_lock);
> +	envp [i++] = scratch;
> +	scratch += sprintf(scratch, "SEQNUM=%ld", sequence_num) + 1;
> +	++sequence_num;
> +	spin_unlock(&sequence_lock);
>
>  	kobj_path_length = get_kobj_path_length (kset, kobj);
>  	kobj_path = kmalloc (kobj_path_length, GFP_KERNEL);

If this kmalloc fails, you'll have a hole in the numbers and
user space will be very confused. You need to report dropped
events if you do this.

	Regards
		Oliver