Re: [PATCH] udev enhancements to use kernel event queue

Robert Love (rml@tech9.net)
12 Jun 2003 16:16:03 -0700


On Thu, 2003-06-12 at 16:09, Greg KH wrote:

> +
> + envp [i++] = scratch;
> + scratch += sprintf(scratch, "SEQNUM=%ld", sequence_num) + 1;
> + ++sequence_num;

Since I do not see a lock in here, I think you need to use atomics?

As is, you can also race and have the same sequence_num value written
out twice.

Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/